third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

index 616bfbe7e474266857090c3ac0f420a9467afbdb..65fa210a14eccf104c954320716ca6f0b826744b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

@@ -364,8 +364,8 @@ bool V8Debugger::setScriptSource(const String16& sourceID, v8::Local<v8::String>

case 1:

{

*exceptionDetails = protocol::Runtime::ExceptionDetails::create()

+ .setExceptionId(m_inspector->nextExceptionId())

.setText(toProtocolStringWithTypeCheck(resultTuple->Get(2)))

- .setScriptId(String16("0"))

.setLineNumber(resultTuple->Get(3)->ToInteger(m_isolate)->Value() - 1)

.setColumnNumber(resultTuple->Get(4)->ToInteger(m_isolate)->Value() - 1).build();

return false;