Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2240613002: [Sync] Convert sync to a static library. (Closed)

Created:
4 years, 4 months ago by maxbogue
Modified:
4 years, 4 months ago
Reviewers:
pavely
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, albertb+watch_chromium.org, sync-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Convert sync to a static library. In preparation for merging in sync_driver, sync is becoming a static library. The driver code has several static_library dependencies that it would probably be bad to duplicate and at least one class (DeviceCountMetricsProvider) which would otherwise need to export a base class from an unrelated component. BUG=633709 Committed: https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16 Cr-Commit-Position: refs/heads/master@{#411851}

Patch Set 1 #

Patch Set 2 : Try getting rid of sync_core source set. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -759 lines) Patch
M components/sync/BUILD.gn View 1 6 chunks +3 lines, -15 lines 0 comments Download
M components/sync/android/sync_jni_registrar.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/api/attachments/attachment.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/attachments/attachment_id.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/attachments/attachment_metadata.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/api/attachments/attachment_store.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/attachments/attachment_store_backend.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/conflict_resolution.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/api/data_batch.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/api/entity_change.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/api/entity_data.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/metadata_batch.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/metadata_change_list.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/api/model_type_change_processor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/model_type_service.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/model_type_store.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/sync_change.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/sync_change_processor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/sync_data.h View 6 chunks +5 lines, -6 lines 0 comments Download
M components/sync/api/sync_error.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/api/sync_error_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/api/sync_merge_result.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/api/syncable_service.h View 2 chunks +2 lines, -4 lines 0 comments Download
M components/sync/base/attachment_id_proto.h View 2 chunks +3 lines, -4 lines 0 comments Download
M components/sync/base/cancelation_observer.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/base/cancelation_signal.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/base/cryptographer.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/base/extensions_activity.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync/base/get_session_name.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/base/invalidation_interface.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/base/model_type.h View 5 chunks +41 lines, -48 lines 0 comments Download
M components/sync/base/nigori.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/base/node_ordinal.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/base/progress_marker_map.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/base/sync_db_util.h View 2 chunks +1 line, -2 lines 0 comments Download
D components/sync/base/sync_export.h View 1 chunk +0 lines, -42 lines 0 comments Download
M components/sync/base/sync_string_conversions.h View 1 chunk +3 lines, -5 lines 0 comments Download
M components/sync/base/syncer_error.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/base/time.h View 1 chunk +3 lines, -4 lines 0 comments Download
M components/sync/base/unique_position.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/base/weak_handle.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/activation_context.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_downloader.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_downloader_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_service.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/attachments/attachment_service_proxy.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/sync/core/attachments/attachment_service_proxy_for_test.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/core/attachments/attachment_store_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/attachments/attachment_uploader.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_uploader_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/core/attachments/attachment_util.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/core/attachments/fake_attachment_downloader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/core/attachments/fake_attachment_uploader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/core/attachments/in_memory_attachment_store.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/core/attachments/on_disk_attachment_store.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/core/base_node.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/base_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/change_record.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/core/data_batch_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/data_type_association_stats.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/core/data_type_debug_info_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/delete_journal.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/http_bridge.h View 3 chunks +5 lines, -6 lines 0 comments Download
M components/sync/core/http_bridge_network_resources.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/http_post_provider_factory.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/http_post_provider_interface.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/core/internal_components_factory.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/internal_components_factory_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/core/model_type_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core/model_type_processor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/model_type_store_backend.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/network_resources.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/non_blocking_sync_common.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/sync/core/processor_entity_tracker.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/read_node.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/core/read_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/shared_model_type_processor.h View 2 chunks +3 lines, -4 lines 0 comments Download
M components/sync/core/shutdown_reason.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core/simple_metadata_change_list.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/sync_encryption_handler.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/sync/core/sync_manager.h View 6 chunks +6 lines, -7 lines 0 comments Download
M components/sync/core/sync_manager_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/core/user_share.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/write_node.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core/write_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core_impl/attachments/proto/BUILD.gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M components/sync/core_impl/debug_info_event_listener.h View 2 chunks +4 lines, -6 lines 0 comments Download
M components/sync/core_impl/js_mutation_event_observer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M components/sync/core_impl/js_sync_encryption_handler_observer.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/core_impl/js_sync_manager_observer.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core_impl/model_type_connector_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core_impl/protocol_event_buffer.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/core_impl/syncapi_internal.h View 2 chunks +2 lines, -6 lines 0 comments Download
M components/sync/core_impl/syncapi_server_connection_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/engine/events/clear_server_data_request_event.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/events/clear_server_data_response_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/events/commit_request_event.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/events/commit_response_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/events/configure_get_updates_request_event.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/events/get_updates_response_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/events/normal_get_updates_request_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/events/poll_get_updates_request_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/events/protocol_event.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/model_safe_worker.h View 4 chunks +8 lines, -11 lines 0 comments Download
M components/sync/engine/passive_model_worker.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine/polling_constants.h View 1 chunk +7 lines, -9 lines 0 comments Download
M components/sync/engine/sync_status.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/apply_control_data_updates.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/engine_impl/backoff_delay_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/clear_server_data.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/commit.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/commit_contribution.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/commit_contributor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/commit_processor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/commit_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/commit_util.h View 3 chunks +6 lines, -9 lines 0 comments Download
M components/sync/engine_impl/directory_commit_contribution.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/directory_update_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/get_commit_ids.h View 2 chunks +4 lines, -5 lines 0 comments Download
M components/sync/engine_impl/get_updates_delegate.h View 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/engine_impl/get_updates_processor.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/model_type_worker.h View 2 chunks +4 lines, -5 lines 0 comments Download
M components/sync/engine_impl/net/server_connection_manager.h View 4 chunks +3 lines, -4 lines 0 comments Download
M components/sync/engine_impl/nudge_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/sync_cycle_event.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/sync_engine_event_listener.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler.h View 4 chunks +3 lines, -4 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M components/sync/engine_impl/syncer.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/syncer_proto_util.h View 2 chunks +3 lines, -5 lines 0 comments Download
M components/sync/engine_impl/syncer_util.h View 2 chunks +4 lines, -6 lines 0 comments Download
M components/sync/engine_impl/update_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/engine_impl/worker_entity_tracker.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/js/js_backend.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/js/js_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/js/js_event_details.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/js/js_event_handler.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/js/sync_js_controller.h View 2 chunks +3 lines, -5 lines 0 comments Download
M components/sync/protocol/BUILD.gn View 1 chunk +1 line, -18 lines 0 comments Download
M components/sync/protocol/proto_enum_conversions.h View 2 chunks +15 lines, -19 lines 0 comments Download
M components/sync/protocol/proto_value_conversions.h View 4 chunks +52 lines, -67 lines 0 comments Download
D components/sync/protocol/sync_proto_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M components/sync/protocol/sync_protocol_error.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/sync/sessions/commit_counters.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/sessions/model_neutral_state.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/sessions/status_counters.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/sessions/sync_session_snapshot.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/sessions/type_debug_info_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/sessions/update_counters.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/sessions_impl/debug_info_getter.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/sessions_impl/directory_type_debug_info_emitter.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/sessions_impl/model_type_registry.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/sessions_impl/nudge_tracker.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/sessions_impl/status_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/sessions_impl/sync_session.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/sessions_impl/sync_session_context.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/directory.h View 4 chunks +3 lines, -4 lines 0 comments Download
M components/sync/syncable/directory_backing_store.h View 3 chunks +3 lines, -4 lines 0 comments Download
M components/sync/syncable/directory_backing_store_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/syncable/directory_change_delegate.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/entry.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/entry_kernel.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/in_memory_directory_backing_store.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/invalid_directory_backing_store.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/syncable/model_neutral_mutable_entry.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/mutable_entry.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/nigori_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/nigori_util.h View 4 chunks +10 lines, -15 lines 0 comments Download
M components/sync/syncable/on_disk_directory_backing_store.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/parent_child_index.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/syncable/scoped_parent_child_index_updater.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/syncable/syncable_base_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_base_write_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_delete_journal.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_enum_conversions.h View 2 chunks +13 lines, -17 lines 0 comments Download
M components/sync/syncable/syncable_id.h View 4 chunks +3 lines, -4 lines 0 comments Download
M components/sync/syncable/syncable_model_neutral_write_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_proto_util.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_read_transaction.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/sync/syncable/syncable_util.h View 2 chunks +8 lines, -12 lines 0 comments Download
M components/sync/syncable/syncable_write_transaction.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync/syncable/transaction_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/test/sessions/mock_debug_info_getter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
maxbogue
Pavel, PTAL! Especially note the three BUILD.gn changes. I wasn't sure of whether to change ...
4 years, 4 months ago (2016-08-11 21:31:57 UTC) #8
pavely
lgtm
4 years, 4 months ago (2016-08-12 23:16:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240613002/20001
4 years, 4 months ago (2016-08-13 00:46:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-13 01:55:47 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 02:00:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35515f47c042be06961058acf4f9eab9a92bab16
Cr-Commit-Position: refs/heads/master@{#411851}

Powered by Google App Engine
This is Rietveld 408576698