Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: components/sync/engine_impl/syncer_util.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine_impl/syncer_proto_util.h ('k') | components/sync/engine_impl/update_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/syncer_util.h
diff --git a/components/sync/engine_impl/syncer_util.h b/components/sync/engine_impl/syncer_util.h
index 5c4d10ca20562fdb431d23c10f5fa12a35e0b7f0..42abcb1b7a175a3e75fa58b87d2746c83109484d 100644
--- a/components/sync/engine_impl/syncer_util.h
+++ b/components/sync/engine_impl/syncer_util.h
@@ -14,7 +14,6 @@
#include <string>
#include <vector>
-#include "components/sync/base/sync_export.h"
#include "components/sync/engine_impl/syncer.h"
#include "components/sync/engine_impl/syncer_types.h"
#include "components/sync/syncable/entry_kernel.h"
@@ -60,16 +59,15 @@ UpdateAttemptResponse AttemptToUpdateEntry(
//
// Will return an invalid position if no valid position can be constructed, or
// if this type does not support positioning.
-SYNC_EXPORT UniquePosition GetUpdatePosition(const sync_pb::SyncEntity& update,
- const std::string& suffix);
+UniquePosition GetUpdatePosition(const sync_pb::SyncEntity& update,
+ const std::string& suffix);
// Fetch the cache_guid and item_id-based unique bookmark tag from an update.
// Will return an empty string if someting unexpected happens.
-SYNC_EXPORT std::string GetUniqueBookmarkTagFromUpdate(
- const sync_pb::SyncEntity& update);
+std::string GetUniqueBookmarkTagFromUpdate(const sync_pb::SyncEntity& update);
// Pass in name to avoid redundant UTF8 conversion.
-SYNC_EXPORT void UpdateServerFieldsFromUpdate(
+void UpdateServerFieldsFromUpdate(
syncable::ModelNeutralMutableEntry* local_entry,
const sync_pb::SyncEntity& server_entry,
const std::string& name);
« no previous file with comments | « components/sync/engine_impl/syncer_proto_util.h ('k') | components/sync/engine_impl/update_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698