Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: components/sync/syncable/syncable_util.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/syncable/syncable_util.h
diff --git a/components/sync/syncable/syncable_util.h b/components/sync/syncable/syncable_util.h
index 323e532c6918d744bb5967aa6f78d1c397b53532..37dbbe95eaf4e5ab8b08060a6bbb9009b67011b9 100644
--- a/components/sync/syncable/syncable_util.h
+++ b/components/sync/syncable/syncable_util.h
@@ -11,7 +11,6 @@
#include <vector>
#include "components/sync/base/model_type.h"
-#include "components/sync/base/sync_export.h"
namespace tracked_objects {
class Location;
@@ -25,30 +24,27 @@ class BaseWriteTransaction;
class ModelNeutralMutableEntry;
class Id;
-SYNC_EXPORT void ChangeEntryIDAndUpdateChildren(BaseWriteTransaction* trans,
- ModelNeutralMutableEntry* entry,
- const Id& new_id);
+void ChangeEntryIDAndUpdateChildren(BaseWriteTransaction* trans,
+ ModelNeutralMutableEntry* entry,
+ const Id& new_id);
-SYNC_EXPORT bool IsLegalNewParent(BaseTransaction* trans,
- const Id& id,
- const Id& parentid);
+bool IsLegalNewParent(BaseTransaction* trans, const Id& id, const Id& parentid);
bool SyncAssert(bool condition,
const tracked_objects::Location& location,
const char* msg,
BaseTransaction* trans);
-SYNC_EXPORT int GetUnsyncedEntries(BaseTransaction* trans,
- std::vector<int64_t>* handles);
+int GetUnsyncedEntries(BaseTransaction* trans, std::vector<int64_t>* handles);
// Generates a fixed-length tag for the given string under the given model_type.
-SYNC_EXPORT std::string GenerateSyncableHash(ModelType model_type,
- const std::string& client_tag);
+std::string GenerateSyncableHash(ModelType model_type,
+ const std::string& client_tag);
// A helper for generating the bookmark type's tag. This is required in more
// than one place, so we define the algorithm here to make sure the
// implementation is consistent.
-SYNC_EXPORT std::string GenerateSyncableBookmarkHash(
+std::string GenerateSyncableBookmarkHash(
const std::string& originator_cache_guid,
const std::string& originator_client_item_id);
« no previous file with comments | « components/sync/syncable/syncable_read_transaction.h ('k') | components/sync/syncable/syncable_write_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698