components/sync/core_impl/attachments/proto/BUILD.gn - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/core_impl/attachments/proto/BUILD.gn

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/core_impl/attachments/proto/BUILD.gn

diff --git a/components/sync/core_impl/attachments/proto/BUILD.gn b/components/sync/core_impl/attachments/proto/BUILD.gn

index 1a8f1b77b53f2bc53317fd54ec4c5c431a7b354a..6ec4b950fdbd5fbe44f1efab0e7386a918696ca0 100644

--- a/components/sync/core_impl/attachments/proto/BUILD.gn

+++ b/components/sync/core_impl/attachments/proto/BUILD.gn

@@ -6,13 +6,9 @@ import("//third_party/protobuf/proto_library.gni")

proto_library("proto") {

# This should only get compiled into the sync component.

- visibility = [ "//components/sync:sync_core" ]

+ visibility = [ "//components/sync" ]

sources = [

"attachment_store.proto",

]

- cc_generator_options = "dllexport_decl=SYNC_EXPORT:"

- cc_include = "components/sync/base/sync_export.h"

- defines = [ "SYNC_IMPLEMENTATION" ]

}