Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: components/sync/engine_impl/commit_util.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/commit_util.h
diff --git a/components/sync/engine_impl/commit_util.h b/components/sync/engine_impl/commit_util.h
index acc86a2da3be08b873be94916ebdaf5c8680b2c7..f3d067357ada4e91d437f3e072c34c8b7f6f214d 100644
--- a/components/sync/engine_impl/commit_util.h
+++ b/components/sync/engine_impl/commit_util.h
@@ -11,7 +11,6 @@
#include "components/sync/base/extensions_activity.h"
#include "components/sync/base/model_type.h"
-#include "components/sync/base/sync_export.h"
#include "components/sync/protocol/sync.pb.h"
namespace sync_pb {
@@ -31,21 +30,20 @@ class BaseWriteTransaction;
namespace commit_util {
// Adds bookmark extensions activity report to |message|.
-SYNC_EXPORT void AddExtensionsActivityToMessage(
+void AddExtensionsActivityToMessage(
ExtensionsActivity* activity,
ExtensionsActivity::Records* extensions_activity_buffer,
sync_pb::CommitMessage* message);
// Fills the config_params field of |message|.
-SYNC_EXPORT void AddClientConfigParamsToMessage(
- ModelTypeSet enabled_types,
- bool cookie_jar_mismatch,
- sync_pb::CommitMessage* message);
+void AddClientConfigParamsToMessage(ModelTypeSet enabled_types,
+ bool cookie_jar_mismatch,
+ sync_pb::CommitMessage* message);
// Takes a snapshot of |meta_entry| and puts it into a protobuf suitable for use
// in a commit request message.
-SYNC_EXPORT void BuildCommitItem(const syncable::Entry& meta_entry,
- sync_pb::SyncEntity* sync_entry);
+void BuildCommitItem(const syncable::Entry& meta_entry,
+ sync_pb::SyncEntity* sync_entry);
// Process a single commit response. Updates the entry's SERVER fields using
// |pb_commit_response| and |pb_committed_entry|.
@@ -53,7 +51,6 @@ SYNC_EXPORT void BuildCommitItem(const syncable::Entry& meta_entry,
// The |deleted_folders| parameter is a set of IDs that represent deleted
// folders. This function will add its entry's ID to this set if it finds
// itself processing a folder deletion.
-SYNC_EXPORT
sync_pb::CommitResponse::ResponseType ProcessSingleCommitResponse(
syncable::BaseWriteTransaction* trans,
const sync_pb::CommitResponse_EntryResponse& server_entry,
« no previous file with comments | « components/sync/engine_impl/commit_queue.h ('k') | components/sync/engine_impl/directory_commit_contribution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698