components/sync/engine_impl/commit.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/commit.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/commit.h

diff --git a/components/sync/engine_impl/commit.h b/components/sync/engine_impl/commit.h

index aec680919d8bdcdfb031dcd80fcaed2d69e42647..fcab48ba7fef0e3ee2786e6c9f675ee487419c8d 100644

--- a/components/sync/engine_impl/commit.h

+++ b/components/sync/engine_impl/commit.h

@@ -14,7 +14,6 @@

#include "base/macros.h"

#include "components/sync/base/extensions_activity.h"

#include "components/sync/base/model_type.h"

-#include "components/sync/base/sync_export.h"

#include "components/sync/base/syncer_error.h"

#include "components/sync/engine/model_safe_worker.h"

#include "components/sync/engine_impl/commit_contribution.h"

@@ -39,7 +38,7 @@ class Syncer;

// been acceptable to let this class be a dumb container object, it turns out

// that there was no other convenient place to put the Init() and

// PostAndProcessCommitResponse() functions. So they ended up here.

-class SYNC_EXPORT Commit {

+class Commit {

public:

typedef std::map<ModelType, std::unique_ptr<CommitContribution>>

ContributionMap;