components/sync/engine_impl/syncer.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/syncer.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/syncer.h

diff --git a/components/sync/engine_impl/syncer.h b/components/sync/engine_impl/syncer.h

index 71c7e4eb4a6a6260b116d803225400c9198e0532..8953bc57c173bb168ac97d812ed26fdfc5e854f0 100644

--- a/components/sync/engine_impl/syncer.h

+++ b/components/sync/engine_impl/syncer.h

@@ -16,7 +16,6 @@

#include "base/synchronization/lock.h"

#include "components/sync/base/extensions_activity.h"

#include "components/sync/base/model_type.h"

-#include "components/sync/base/sync_export.h"

#include "components/sync/engine_impl/conflict_resolver.h"

#include "components/sync/engine_impl/syncer_types.h"

#include "components/sync/sessions_impl/sync_session.h"

@@ -36,7 +35,7 @@ class GetUpdatesProcessor;

// A Syncer instance expects to run on a dedicated thread. Calls to SyncShare()

// may take an unbounded amount of time because it may block on network I/O, on

// lock contention, or on tasks posted to other threads.

-class SYNC_EXPORT Syncer {

+class Syncer {

public:

typedef std::vector<int64_t> UnsyncedMetaHandles;