Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: components/sync/protocol/BUILD.gn

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/js/sync_js_controller.h ('k') | components/sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/BUILD.gn
diff --git a/components/sync/protocol/BUILD.gn b/components/sync/protocol/BUILD.gn
index 209f26ccf28923f4a14abb8bdf03b623d5763bb6..50c3e7fa9a627543569d4bc221c81323475aa576 100644
--- a/components/sync/protocol/BUILD.gn
+++ b/components/sync/protocol/BUILD.gn
@@ -5,24 +5,7 @@
import("//third_party/protobuf/proto_library.gni")
import("protocol_sources.gni")
-# This must be a component for the dependency structure we have now, but the
-# proto_library generates a source set. Link those into a component.
-component("protocol") {
- public_deps = [
- ":protocol_internal",
- ]
-}
-
-proto_library("protocol_internal") {
- visibility = [ ":protocol" ]
-
+proto_library("protocol") {
sources = sync_protocol_sources
-
- cc_generator_options = "dllexport_decl=SYNC_PROTO_EXPORT:"
- cc_include = "components/sync/protocol/sync_proto_export.h"
- component_build_force_source_set = true
-
- defines = [ "SYNC_PROTO_IMPLEMENTATION" ]
-
extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
}
« no previous file with comments | « components/sync/js/sync_js_controller.h ('k') | components/sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698