components/sync/syncable/entry_kernel.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/entry_kernel.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/entry_kernel.h

diff --git a/components/sync/syncable/entry_kernel.h b/components/sync/syncable/entry_kernel.h

index 4895b2829ae6b784c2abb70f37e0c5909ce3e748..03a2ff1e8a16206a1d005b773ca515fcbd5a6d73 100644

--- a/components/sync/syncable/entry_kernel.h

+++ b/components/sync/syncable/entry_kernel.h

@@ -17,7 +17,6 @@

#include "components/sync/base/immutable.h"

#include "components/sync/base/model_type.h"

#include "components/sync/base/proto_value_ptr.h"

-#include "components/sync/base/sync_export.h"

#include "components/sync/base/time.h"

#include "components/sync/base/unique_position.h"

#include "components/sync/protocol/attachments.pb.h"

@@ -193,7 +192,7 @@ enum BitTemp {

enum { BIT_TEMPS_COUNT = BIT_TEMPS_END - BIT_TEMPS_BEGIN };

-struct SYNC_EXPORT EntryKernel {

+struct EntryKernel {

private:

typedef syncer::ProtoValuePtr<sync_pb::EntitySpecifics> EntitySpecificsPtr;

typedef syncer::ProtoValuePtr<sync_pb::AttachmentMetadata>