components/sync/engine_impl/get_commit_ids.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/get_commit_ids.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/get_commit_ids.h

diff --git a/components/sync/engine_impl/get_commit_ids.h b/components/sync/engine_impl/get_commit_ids.h

index fa318b3272c111f605c6adff864e0b54859a1c7e..9ba4214b16f512dfbb06e300a60d3d7185b845d6 100644

--- a/components/sync/engine_impl/get_commit_ids.h

+++ b/components/sync/engine_impl/get_commit_ids.h

@@ -11,7 +11,6 @@

#include <vector>

#include "components/sync/base/model_type.h"

-#include "components/sync/base/sync_export.h"

#include "components/sync/syncable/directory.h"

using std::vector;

@@ -31,10 +30,10 @@ class BaseTransaction;

// This function also enforces some position ordering constraints that are no

// longer necessary. We should relax those constraints. See crbug.com/287938.

-SYNC_EXPORT void GetCommitIdsForType(syncable::BaseTransaction* trans,

- ModelType type,

- size_t max_entries,

- std::vector<int64_t>* out);

+void GetCommitIdsForType(syncable::BaseTransaction* trans,

+ ModelType type,

+ size_t max_entries,

+ std::vector<int64_t>* out);

} // namespace syncer