Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/sync/engine/model_safe_worker.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine/events/protocol_event.h ('k') | components/sync/engine/passive_model_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine/model_safe_worker.h
diff --git a/components/sync/engine/model_safe_worker.h b/components/sync/engine/model_safe_worker.h
index df296303645b3ecf93c6c76d7a9be3595683e2b7..42eb29c1c106d45b753f61b13dbec9527a0b7541 100644
--- a/components/sync/engine/model_safe_worker.h
+++ b/components/sync/engine/model_safe_worker.h
@@ -17,7 +17,6 @@
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
#include "components/sync/base/model_type.h"
-#include "components/sync/base/sync_export.h"
#include "components/sync/base/syncer_error.h"
namespace base {
@@ -49,7 +48,7 @@ enum ModelSafeGroup {
// SyncBackendRegistrar involvement.
};
-SYNC_EXPORT std::string ModelSafeGroupToString(ModelSafeGroup group);
+std::string ModelSafeGroupToString(ModelSafeGroup group);
// WorkerLoopDestructionObserver is notified when the thread where it works
// is going to be destroyed.
@@ -68,9 +67,8 @@ class WorkerLoopDestructionObserver {
// a thread and does actual work on that thread. On the destruction of that
// thread, the affiliated worker is effectively disabled to do more
// work and will notify its observer.
-class SYNC_EXPORT ModelSafeWorker
- : public base::RefCountedThreadSafe<ModelSafeWorker>,
- public base::MessageLoop::DestructionObserver {
+class ModelSafeWorker : public base::RefCountedThreadSafe<ModelSafeWorker>,
+ public base::MessageLoop::DestructionObserver {
public:
// Subclass should implement to observe destruction of the loop where
// it actually does work. Called on UI thread immediately after worker is
@@ -151,17 +149,16 @@ class SYNC_EXPORT ModelSafeWorker
typedef std::map<ModelType, ModelSafeGroup> ModelSafeRoutingInfo;
// Caller takes ownership of return value.
-SYNC_EXPORT std::unique_ptr<base::DictionaryValue> ModelSafeRoutingInfoToValue(
+std::unique_ptr<base::DictionaryValue> ModelSafeRoutingInfoToValue(
const ModelSafeRoutingInfo& routing_info);
-SYNC_EXPORT std::string ModelSafeRoutingInfoToString(
+std::string ModelSafeRoutingInfoToString(
const ModelSafeRoutingInfo& routing_info);
-SYNC_EXPORT ModelTypeSet
-GetRoutingInfoTypes(const ModelSafeRoutingInfo& routing_info);
+ModelTypeSet GetRoutingInfoTypes(const ModelSafeRoutingInfo& routing_info);
-SYNC_EXPORT ModelSafeGroup
-GetGroupForModelType(const ModelType type, const ModelSafeRoutingInfo& routes);
+ModelSafeGroup GetGroupForModelType(const ModelType type,
+ const ModelSafeRoutingInfo& routes);
} // namespace syncer
« no previous file with comments | « components/sync/engine/events/protocol_event.h ('k') | components/sync/engine/passive_model_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698