components/sync/syncable/syncable_base_transaction.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/syncable_base_transaction.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/syncable_base_transaction.h

diff --git a/components/sync/syncable/syncable_base_transaction.h b/components/sync/syncable/syncable_base_transaction.h

index 5312d13ab24848a2accc6a010db1fbd1d7d808a7..fe232a8cbf81cc279cfdbbc24b385cee6038a7c9 100644

--- a/components/sync/syncable/syncable_base_transaction.h

+++ b/components/sync/syncable/syncable_base_transaction.h

@@ -9,7 +9,6 @@

#include "base/location.h"

#include "base/macros.h"

-#include "components/sync/base/sync_export.h"

#include "components/sync/syncable/syncable_id.h"

namespace syncer {

@@ -34,7 +33,7 @@ enum WriterTag {

// Make sure to update this if you update WriterTag.

std::string WriterTagToString(WriterTag writer_tag);

-class SYNC_EXPORT BaseTransaction {

+class BaseTransaction {

public:

static Id root_id();