components/sync/core_impl/syncapi_internal.h - Issue 2240613002: [Sync] Convert sync to a static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/core_impl/syncapi_internal.h

Issue 2240613002: [Sync] Convert sync to a static library. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try getting rid of sync_core source set. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/core_impl/syncapi_internal.h

diff --git a/components/sync/core_impl/syncapi_internal.h b/components/sync/core_impl/syncapi_internal.h

index c53467f646f60410df2b59d8a8aa2e8308e2abba..443bf35ff938e6318cf016a151b202c9b1e1e789 100644

--- a/components/sync/core_impl/syncapi_internal.h

+++ b/components/sync/core_impl/syncapi_internal.h

@@ -10,8 +10,6 @@

#include <string>

-#include "components/sync/base/sync_export.h"

namespace sync_pb {

class AttachmentMetadata;

class EntitySpecifics;

@@ -26,10 +24,8 @@ sync_pb::PasswordSpecificsData* DecryptPasswordSpecifics(

const sync_pb::EntitySpecifics& specifics,

Cryptographer* crypto);

-SYNC_EXPORT void SyncAPINameToServerName(const std::string& syncer_name,

- std::string* out);

-SYNC_EXPORT void ServerNameToSyncAPIName(const std::string& server_name,

- std::string* out);

+void SyncAPINameToServerName(const std::string& syncer_name, std::string* out);

+void ServerNameToSyncAPIName(const std::string& server_name, std::string* out);

bool IsNameServerIllegalAfterTrimming(const std::string& name);