Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2220973002: [turbofan] Remove the FloatXXSubPreserveNan operators. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the FloatXXSubPreserveNan operators. This CL changes the semantics of FloatXXSub to match the semantics of the semantics of FloatXXSubPreserveNan. Therefore there is no need anymore for the FloatXXSubPreserveNan operators. The optimizations in VisitFloatXXSub which are removed in this CL have already been moved to machine-operator-reducer.cc in https://codereview.chromium.org/2226663002 R=bmeurer@chromium.org Committed: https://crrev.com/f8938e50964e7b83818a0fff7fc0f2b065f8bf49 Cr-Commit-Position: refs/heads/master@{#38437}

Patch Set 1 #

Patch Set 2 : Remove stale tests. #

Patch Set 3 : Reintroduce an optimization for arm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -512 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 2 1 chunk +12 lines, -58 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +0 lines, -82 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 1 chunk +0 lines, -65 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
ahaas
4 years, 4 months ago (2016-08-08 09:11:25 UTC) #1
Benedikt Meurer
Awesome, LGTM! Thanks.
4 years, 4 months ago (2016-08-08 09:12:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220973002/30001
4 years, 4 months ago (2016-08-08 12:03:00 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 4 months ago (2016-08-08 12:09:02 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 12:10:00 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f8938e50964e7b83818a0fff7fc0f2b065f8bf49
Cr-Commit-Position: refs/heads/master@{#38437}

Powered by Google App Engine
This is Rietveld 408576698