Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2226663002: [turbofan] Lower "-0.0 - x" in the MachineOperatorReducer. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower "-0.0 - x" in the MachineOperatorReducer. Up until now "-0.0 - x" was lowered in the instruction selector. I moved the lowering now to the MachineOperatorReducer. I did not remove the lowering from the instruction selector yet, I would prefer to do that in a separate CL. R=bmeurer@chromium.org Committed: https://crrev.com/552601bb5f4158f6d9ca6d4da8cab31cc79dd1b9 Cr-Commit-Position: refs/heads/master@{#38417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -5 lines) Patch
M src/compiler/machine-operator-reducer.cc View 2 chunks +51 lines, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 5 chunks +62 lines, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 4 months ago (2016-08-08 08:10:56 UTC) #1
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-08 08:37:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226663002/1
4 years, 4 months ago (2016-08-08 08:37:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 08:39:43 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 08:40:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/552601bb5f4158f6d9ca6d4da8cab31cc79dd1b9
Cr-Commit-Position: refs/heads/master@{#38417}

Powered by Google App Engine
This is Rietveld 408576698