PasswordForm -> FormDigest for GetLogins

PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
Committed: https://crrev.com/40c87a312f8a900ae236d7329b0303b54f842150
Cr-Commit-Position: refs/heads/master@{#406799}

[vabr (Chromium), 2016-07-14 11:42:01]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 11:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 12:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 12:18:49]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-07-14 13:46:39]

Description was changed from

==========
PasswordForm -> FormDigest for GetLogins

This is WIP.
COMMIT=false

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
==========

to

==========
PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
==========

[vabr (Chromium), 2016-07-14 13:48:32]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-07-14 13:48:34]

Hi Vadym!

Thanks for all the great reviews so far. I have another CL I'd like your review
of! :)

This is definitely not urgent. I'm OOO until Monday, and you are of course
welcome to take the time you need after that as well.

Cheers,
Vaclav

[dvadym, 2016-07-20 13:43:02]

Thanks Vaclav for this refactoring!
LGTM % nits

https://codereview.chromium.org/2133953002/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/native_backend_libsecret.cc (right):

https://codereview.chromium.org/2133953002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/native_backend_libsecret.cc:332:
PasswordStore::FormDigest form = {
nit: Why don't to use constructor of FormDigest that takes PasswordForm?

https://codereview.chromium.org/2133953002/diff/100001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/2133953002/diff/100001/components/password_ma...
components/password_manager/core/browser/password_form_manager.cc:423: this);
Nit:Why don't to use constructor of FormDigest that takes PasswordForm?

[vabr (Chromium), 2016-07-20 14:12:18]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 14:12:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-07-20 14:13:05]

vabr@chromium.org changed reviewers:
+ stanisc@chromium.org

[vabr (Chromium), 2016-07-20 14:13:06]

Thanks, Vadym!

Stanislav, could you please review
chrome/browser/sync/test/integration/passwords_helper.cc ?

Thank you,
Vaclav

https://codereview.chromium.org/2133953002/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/native_backend_libsecret.cc (right):

https://codereview.chromium.org/2133953002/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/native_backend_libsecret.cc:332:
PasswordStore::FormDigest form = {
On 2016/07/20 13:43:02, dvadym wrote:
> nit: Why don't to use constructor of FormDigest that takes PasswordForm?

Done.

https://codereview.chromium.org/2133953002/diff/100001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.cc (right):

https://codereview.chromium.org/2133953002/diff/100001/components/password_ma...
components/password_manager/core/browser/password_form_manager.cc:423: this);
On 2016/07/20 13:43:02, dvadym wrote:
> Nit:Why don't to use constructor of FormDigest that takes PasswordForm?

Done.

[commit-bot: I haz the power, 2016-07-20 15:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:20:22]

Dry run: This issue passed the CQ dry run.

[stanisc, 2016-07-20 19:42:02]

passwords_helper.cc lgtm

[vabr (Chromium), 2016-07-21 07:48:03]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-07-21 07:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org
Link to the patchset: https://codereview.chromium.org/2133953002/#ps140001
(title: "Nits addressed")

[commit-bot: I haz the power, 2016-07-21 07:48:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:51:57]

Description was changed from

==========
PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
==========

to

==========
PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
==========

[commit-bot: I haz the power, 2016-07-21 07:51:58]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-07-21 07:53:27]

Description was changed from

==========
PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355
==========

to

==========
PasswordForm -> FormDigest for GetLogins

This CL restricts the data passed to GetLogins and related methods. Instead of
passing the whole of a PasswordForm, it only passes the data relevant for the
credential retrieval -- the data contained in the newly introduced FormDigest
struct: scheme, realm and origin.

BUG=621355

Committed: https://crrev.com/40c87a312f8a900ae236d7329b0303b54f842150
Cr-Commit-Position: refs/heads/master@{#406799}
==========

[commit-bot: I haz the power, 2016-07-21 07:53:28]

Patchset 8 (id:??) landed as
https://crrev.com/40c87a312f8a900ae236d7329b0303b54f842150
Cr-Commit-Position: refs/heads/master@{#406799}