chrome/browser/sync/test/integration/passwords_helper.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/passwords_helper.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/test/integration/passwords_helper.cc

diff --git a/chrome/browser/sync/test/integration/passwords_helper.cc b/chrome/browser/sync/test/integration/passwords_helper.cc

index 64fb1d9dcfcbcf267461e3e098e61c7e6de0b04f..61d3c73d8d49e6add8fac3cdac05a154dc7e8414 100644

--- a/chrome/browser/sync/test/integration/passwords_helper.cc

+++ b/chrome/browser/sync/test/integration/passwords_helper.cc

@@ -95,8 +95,8 @@ void UpdateLogin(PasswordStore* store, const PasswordForm& form) {

ScopedVector<PasswordForm> GetLogins(PasswordStore* store) {

EXPECT_TRUE(store);

- PasswordForm matcher_form;

- matcher_form.signon_realm = kFakeSignonRealm;

+ password_manager::PasswordStore::FormDigest matcher_form = {

+ PasswordForm::SCHEME_HTML, kFakeSignonRealm, GURL()};

PasswordStoreConsumerHelper consumer;

store->GetLogins(matcher_form, &consumer);

content::RunMessageLoop();