components/password_manager/core/browser/credential_manager_pending_request_task.h - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.h

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliated_match_helper_unittest.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.h

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.h b/components/password_manager/core/browser/credential_manager_pending_request_task.h

index 1cafaf1bd438a60f51e876255797f23b29ff01e9..2994bf377924bda5a78022ba0c4bd066e1a815d2 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.h

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.h

@@ -12,6 +12,7 @@

#include "base/callback_forward.h"

#include "base/macros.h"

#include "base/memory/scoped_vector.h"

+#include "components/password_manager/core/browser/password_store.h"

#include "components/password_manager/core/browser/password_store_consumer.h"

#include "url/gurl.h"

@@ -38,7 +39,7 @@ class CredentialManagerPendingRequestTaskDelegate {

virtual GURL GetOrigin() const = 0;

// Retrieves a synthetic PasswordForm for the current page origin.

- virtual autofill::PasswordForm GetSynthesizedFormForOrigin() const = 0;

+ virtual PasswordStore::FormDigest GetSynthesizedFormForOrigin() const = 0;

// Returns the PasswordManagerClient.

virtual PasswordManagerClient* client() const = 0;