components/password_manager/core/browser/password_store_default_unittest.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc

index 9dffaa2060b90e4d289503c39f8d218d6ba2c823..566e43f5b0691d52c788bf6df538d202e1e98e46 100644

--- a/components/password_manager/core/browser/password_store_default_unittest.cc

+++ b/components/password_manager/core/browser/password_store_default_unittest.cc

@@ -268,7 +268,7 @@ TEST(PasswordStoreDefaultTest, OperationsOnABadDatabaseSilentlyFail) {

// Get all logins; autofillable logins; blacklisted logins.

testing::StrictMock<MockPasswordStoreConsumer> mock_consumer;

EXPECT_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef(IsEmpty()));

- bad_store->GetLogins(*form, &mock_consumer);

+ bad_store->GetLogins(PasswordStore::FormDigest(*form), &mock_consumer);

base::RunLoop().RunUntilIdle();

testing::Mock::VerifyAndClearExpectations(&mock_consumer);

EXPECT_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef(IsEmpty()));