chrome/browser/password_manager/password_store_proxy_mac_unittest.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_proxy_mac.cc ('k') | chrome/browser/password_manager/password_store_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

index 8837d061f876267483a9112d56e740d29549e191..6496af84303855562cb5d2ce6ba462b4a10f2027 100644

--- a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

+++ b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc

@@ -34,6 +34,7 @@ namespace {

using autofill::PasswordForm;

using content::BrowserThread;

using password_manager::MigrationStatus;

+using password_manager::PasswordStore;

using password_manager::PasswordStoreChange;

using password_manager::PasswordStoreChangeList;

using testing::_;

@@ -178,7 +179,8 @@ void PasswordStoreProxyMacTest::FinishAsyncProcessing() {

// Do a store-level query to wait for all the previously enqueued operations

// to finish.

MockPasswordStoreConsumer consumer;

- store_->GetLogins(PasswordForm(), &consumer);

+ store_->GetLogins({PasswordForm::SCHEME_HTML, std::string(), GURL()},

+ &consumer);

EXPECT_CALL(consumer, OnGetPasswordStoreResultsConstRef(_))

.WillOnce(QuitUIMessageLoop());

base::RunLoop().Run();

@@ -314,7 +316,7 @@ TEST_P(PasswordStoreProxyMacTest, FillLogins) {

AddForm(blacklisted_form);

MockPasswordStoreConsumer mock_consumer;

- store()->GetLogins(password_form, &mock_consumer);

+ store()->GetLogins(PasswordStore::FormDigest(password_form), &mock_consumer);

EXPECT_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef(

ElementsAre(Pointee(password_form))))

.WillOnce(QuitUIMessageLoop());

@@ -373,7 +375,7 @@ TEST_P(PasswordStoreProxyMacTest, OperationsOnABadDatabaseSilentlyFail) {

// Get all logins; autofillable logins; blacklisted logins.

MockPasswordStoreConsumer mock_consumer;

- store()->GetLogins(*form, &mock_consumer);

+ store()->GetLogins(PasswordStore::FormDigest(*form), &mock_consumer);

ON_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef(_))

.WillByDefault(QuitUIMessageLoop());

EXPECT_CALL(mock_consumer, OnGetPasswordStoreResultsConstRef(IsEmpty()));

@@ -467,7 +469,7 @@ void PasswordStoreProxyMacMigrationTest::TestMigration(bool lock_keychain) {

->set_locked(false);

}

MockPasswordStoreConsumer mock_consumer;

- store()->GetLogins(form, &mock_consumer);

+ store()->GetLogins(PasswordStore::FormDigest(form), &mock_consumer);

EXPECT_CALL(mock_consumer,

OnGetPasswordStoreResultsConstRef(ElementsAre(Pointee(form))))

.WillOnce(QuitUIMessageLoop());