Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Patch Set: Nits addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac.cc
diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc
index b7d1b14f393e7179b6dc8bd9c8ad4921b97d6d8a..8efe36082c871110bb41027978cfd2e77282aebc 100644
--- a/chrome/browser/password_manager/password_store_mac.cc
+++ b/chrome/browser/password_manager/password_store_mac.cc
@@ -1236,7 +1236,7 @@ bool PasswordStoreMac::RemoveStatisticsCreatedBetweenImpl(
}
ScopedVector<autofill::PasswordForm> PasswordStoreMac::FillMatchingLogins(
- const autofill::PasswordForm& form) {
+ const FormDigest& form) {
chrome::ScopedSecKeychainSetUserInteractionAllowed user_interaction_allowed(
false);
@@ -1345,7 +1345,8 @@ bool PasswordStoreMac::DatabaseHasFormMatchingKeychainForm(
DCHECK(login_metadata_db_);
bool has_match = false;
ScopedVector<autofill::PasswordForm> database_forms;
- if (!login_metadata_db_->GetLogins(form, &database_forms))
+ if (!login_metadata_db_->GetLogins(
+ password_manager::PasswordStore::FormDigest(form), &database_forms))
return false;
for (const autofill::PasswordForm* db_form : database_forms) {
// Below we filter out fuzzy matched forms because we are only interested
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.h ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698