Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Patch Set: Nits addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 90711f8be6311164ab85c0eb4be9a0d79ef4ffaf..899e77d5dd6fa2cb3067ebcfe0a858d358ef4806 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -27,6 +27,7 @@
using autofill::PasswordForm;
using base::UTF8ToUTF16;
using base::UTF16ToUTF8;
+using password_manager::PasswordStore;
namespace {
const char kEmptyString[] = "";
@@ -298,7 +299,7 @@ bool NativeBackendLibsecret::DisableAutoSignInForOrigins(
}
bool NativeBackendLibsecret::GetLogins(
- const PasswordForm& form,
+ const PasswordStore::FormDigest& form,
ScopedVector<autofill::PasswordForm>* forms) {
return GetLoginsList(&form, ALL_LOGINS, forms);
}
@@ -328,7 +329,8 @@ bool NativeBackendLibsecret::AddUpdateLoginSearch(
return false;
}
- *forms = ConvertFormList(found, &lookup_form);
+ PasswordStore::FormDigest form(lookup_form);
+ *forms = ConvertFormList(found, &form);
return true;
}
@@ -402,7 +404,7 @@ bool NativeBackendLibsecret::GetAllLogins(
}
bool NativeBackendLibsecret::GetLoginsList(
- const PasswordForm* lookup_form,
+ const PasswordStore::FormDigest* lookup_form,
GetLoginsListOptions options,
ScopedVector<autofill::PasswordForm>* forms) {
LibsecretAttributesBuilder attrs;
@@ -498,7 +500,7 @@ bool NativeBackendLibsecret::RemoveLoginsBetween(
ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(
GList* found,
- const PasswordForm* lookup_form) {
+ const PasswordStore::FormDigest* lookup_form) {
ScopedVector<autofill::PasswordForm> forms;
password_manager::PSLDomainMatchMetric psl_domain_match_metric =
password_manager::PSL_DOMAIN_MATCH_NONE;

Powered by Google App Engine
This is Rietveld 408576698