components/password_manager/core/browser/password_store_default.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index 1a7b647eb6ede6b6bc4c22a841f33777a0c0249a..3de79c88a2f68a636db7b1c4b731bd2973d473bb 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -172,7 +172,7 @@ bool PasswordStoreDefault::RemoveStatisticsCreatedBetweenImpl(

}

ScopedVector<autofill::PasswordForm> PasswordStoreDefault::FillMatchingLogins(

- const autofill::PasswordForm& form) {

+ const FormDigest& form) {

ScopedVector<autofill::PasswordForm> matched_forms;

if (login_db_ && !login_db_->GetLogins(form, &matched_forms))

return ScopedVector<autofill::PasswordForm>();