components/password_manager/core/browser/login_database.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/login_database.cc

diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc

index 3c227a27d072fcfa92340a9f19f296d5cf1983f5..c51f1f90df24d4dd015d7beb0dba84fabaeaf34d 100644

--- a/components/password_manager/core/browser/login_database.cc

+++ b/components/password_manager/core/browser/login_database.cc

@@ -1028,7 +1028,7 @@ LoginDatabase::EncryptionResult LoginDatabase::InitPasswordFormFromStatement(

}

bool LoginDatabase::GetLogins(

- const PasswordForm& form,

+ const PasswordStore::FormDigest& form,

ScopedVector<autofill::PasswordForm>* forms) const {

DCHECK(forms);

const GURL signon_realm(form.signon_realm);

@@ -1181,7 +1181,7 @@ std::string LoginDatabase::GetEncryptedPassword(

// static

bool LoginDatabase::StatementToForms(

sql::Statement* statement,

- const autofill::PasswordForm* matched_form,

+ const PasswordStore::FormDigest* matched_form,

ScopedVector<autofill::PasswordForm>* forms) {

PSLDomainMatchMetric psl_domain_match_metric = PSL_DOMAIN_MATCH_NONE;