Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/password_manager/core/browser/login_database_ios_unittest.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Patch Set: Nits addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/login_database_ios_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_ios_unittest.cc b/components/password_manager/core/browser/login_database_ios_unittest.cc
index 856cf9f28ff0ab61dbc02e3dcdb0d52cff4ea579..201bafe5fbe7108bac47308b2649e24ec5b2e72d 100644
--- a/components/password_manager/core/browser/login_database_ios_unittest.cc
+++ b/components/password_manager/core/browser/login_database_ios_unittest.cc
@@ -116,10 +116,8 @@ TEST_F(LoginDatabaseIOSTest, UpdateLogin) {
login_db_->UpdateLogin(form);
ASSERT_EQ(1u, changes.size());
- form.password_value = base::string16();
-
ScopedVector<PasswordForm> forms;
- EXPECT_TRUE(login_db_->GetLogins(form, &forms));
+ EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));
ASSERT_EQ(1U, forms.size());
EXPECT_STREQ("secret", UTF16ToUTF8(forms[0]->password_value).c_str());
@@ -138,7 +136,7 @@ TEST_F(LoginDatabaseIOSTest, RemoveLogin) {
ignore_result(login_db_->RemoveLogin(form));
ScopedVector<PasswordForm> forms;
- EXPECT_TRUE(login_db_->GetLogins(form, &forms));
+ EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));
ASSERT_EQ(0U, forms.size());
ASSERT_EQ(0U, GetKeychainSize());
@@ -171,8 +169,8 @@ TEST_F(LoginDatabaseIOSTest, RemoveLoginsCreatedBetween) {
login_db_->RemoveLoginsCreatedBetween(base::Time::FromDoubleT(150),
base::Time::FromDoubleT(250));
- PasswordForm form;
- form.signon_realm = "http://www.example.com";
+ PasswordStore::FormDigest form = {PasswordForm::SCHEME_HTML,
+ "http://www.example.com", GURL()};
ScopedVector<PasswordForm> logins;
EXPECT_TRUE(login_db_->GetLogins(form, &logins));

Powered by Google App Engine
This is Rietveld 408576698