Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6007)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Patch Set: Nits addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index b7ea954d6af09f7b6aa911f5bf12aea0d47a4e24..f9db9a3cf45a9f4607032b182bf19031c3bac80c 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -27,6 +27,7 @@
using autofill::PasswordForm;
using base::UTF8ToUTF16;
using base::UTF16ToUTF8;
+using password_manager::PasswordStore;
using password_manager::PasswordStoreChange;
using password_manager::PasswordStoreChangeList;
using testing::Pointee;
@@ -426,15 +427,13 @@ class NativeBackendLibsecretTest : public testing::Test {
VerifiedAdd(&backend, credentials);
- PasswordForm target_form;
- target_form.origin = url;
- target_form.signon_realm = url.spec();
+ PasswordStore::FormDigest target_form = {PasswordForm::SCHEME_HTML,
+ url.spec(), url};
if (scheme != PasswordForm::SCHEME_HTML) {
// For non-HTML forms, the realm used for authentication
// (http://tools.ietf.org/html/rfc1945#section-10.2) is appended to the
// signon_realm. Just use a default value for now.
target_form.signon_realm.append("Realm");
- target_form.scheme = scheme;
}
ScopedVector<autofill::PasswordForm> form_list;
EXPECT_TRUE(backend.GetLogins(target_form, &form_list));
@@ -465,9 +464,8 @@ class NativeBackendLibsecretTest : public testing::Test {
// Get the PSL-matched copy of the saved login for m.facebook.
const GURL kMobileURL("http://m.facebook.com/");
- PasswordForm m_facebook_lookup;
- m_facebook_lookup.origin = kMobileURL;
- m_facebook_lookup.signon_realm = kMobileURL.spec();
+ PasswordStore::FormDigest m_facebook_lookup = {
+ PasswordForm::SCHEME_HTML, kMobileURL.spec(), kMobileURL};
ScopedVector<autofill::PasswordForm> form_list;
EXPECT_TRUE(backend.GetLogins(m_facebook_lookup, &form_list));
@@ -514,7 +512,8 @@ class NativeBackendLibsecretTest : public testing::Test {
form_list.clear();
// Check that www.facebook.com login was modified by the update.
- EXPECT_TRUE(backend.GetLogins(form_facebook_, &form_list));
+ EXPECT_TRUE(backend.GetLogins(PasswordStore::FormDigest(form_facebook_),
+ &form_list));
// There should be two results -- the exact one, and the PSL-matched one.
EXPECT_EQ(2u, form_list.size());
index_non_psl = 0;
« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | chrome/browser/password_manager/password_store_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698