Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.h

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Patch Set: Nits addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.h
diff --git a/chrome/browser/password_manager/native_backend_libsecret.h b/chrome/browser/password_manager/native_backend_libsecret.h
index bfdf5bfc7ac6043d0158df400c7c52d407b1d51e..2f5f7772834ecf8dd14cd827a26df4b95a2c4703 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.h
+++ b/chrome/browser/password_manager/native_backend_libsecret.h
@@ -46,7 +46,7 @@ class NativeBackendLibsecret : public PasswordStoreX::NativeBackend {
bool DisableAutoSignInForOrigins(
const base::Callback<bool(const GURL&)>& origin_filter,
password_manager::PasswordStoreChangeList* changes) override;
- bool GetLogins(const autofill::PasswordForm& form,
+ bool GetLogins(const password_manager::PasswordStore::FormDigest& form,
ScopedVector<autofill::PasswordForm>* forms) override;
bool GetAutofillableLogins(
ScopedVector<autofill::PasswordForm>* forms) override;
@@ -76,10 +76,10 @@ class NativeBackendLibsecret : public PasswordStoreX::NativeBackend {
// Retrieves credentials matching |options| from the keyring into |forms|,
// overwriting the original contents of |forms|. If |lookup_form| is not NULL,
// only retrieves credentials PSL-matching it. Returns true on success.
- bool GetLoginsList(const autofill::PasswordForm* lookup_form,
- GetLoginsListOptions options,
- ScopedVector<autofill::PasswordForm>* forms)
- WARN_UNUSED_RESULT;
+ bool GetLoginsList(
+ const password_manager::PasswordStore::FormDigest* lookup_form,
+ GetLoginsListOptions options,
+ ScopedVector<autofill::PasswordForm>* forms) WARN_UNUSED_RESULT;
// Retrieves password created/synced in the time interval into |forms|,
// overwriting the original contents of |forms|. Returns true on success.
@@ -96,10 +96,11 @@ class NativeBackendLibsecret : public PasswordStoreX::NativeBackend {
TimestampToCompare date_to_compare,
password_manager::PasswordStoreChangeList* changes);
- // convert data get from Libsecret to Passwordform
+ // Convert data get from Libsecret to Passwordform. Uses |lookup_form| for
+ // additional (PSL) matching, if present.
ScopedVector<autofill::PasswordForm> ConvertFormList(
GList* found,
- const autofill::PasswordForm* lookup_form);
+ const password_manager::PasswordStore::FormDigest* lookup_form);
// The app string, possibly based on the local profile id.
std::string app_string_;

Powered by Google App Engine
This is Rietveld 408576698