components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_pending_request_task.cc ('k') | components/password_manager/core/browser/login_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc b/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc

index 8cf5b31bf420aa8bbd1307894193c922e9e622fa..d8bc5b800d12255483b3c13e8e030e20084b0958 100644

--- a/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc

@@ -46,7 +46,8 @@ void CredentialManagerPendingRequireUserMediationTask::

net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);

if (registrable_domains_.count(form_registrable_domain) ||

(affiliated_realms_.count(form->signon_realm) &&

- AffiliatedMatchHelper::IsValidAndroidCredential(*form))) {

+ AffiliatedMatchHelper::IsValidAndroidCredential(

+ PasswordStore::FormDigest(*form)))) {

form->skip_zero_click = true;

// Note that UpdateLogin ends up copying the form while posting a task to

// update the PasswordStore, so it's fine to let |results| delete the