chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc - Issue 2133953002: PasswordForm -> FormDigest for GetLogins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 2133953002: PasswordForm -> FormDigest for GetLogins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid

Patch Set: Nits addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/native_backend_libsecret.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

index ac64487d7356653181ad56d065018e6995d6d014..e64e16b74c4ba9178add284d807647f9009dc378 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

@@ -957,14 +957,15 @@ TEST_P(NativeBackendKWalletTest, AndroidCredentials) {

NativeBackendKWalletStub backend(42, desktop_env_);

EXPECT_TRUE(backend.InitWithBus(mock_session_bus_));

- PasswordForm observed_android_form;

- observed_android_form.scheme = PasswordForm::SCHEME_HTML;

- observed_android_form.signon_realm =

+ PasswordForm saved_android_form;

+ saved_android_form.scheme = PasswordForm::SCHEME_HTML;

+ saved_android_form.signon_realm =

"android://7x7IDboo8u9YKraUsbmVkuf1-@net.rateflix.app/";

- PasswordForm saved_android_form = observed_android_form;

saved_android_form.username_value = base::UTF8ToUTF16("randomusername");

saved_android_form.password_value = base::UTF8ToUTF16("password");

+ password_manager::PasswordStore::FormDigest observed_android_form(

+ saved_android_form);

BrowserThread::PostTaskAndReplyWithResult(

BrowserThread::DB, FROM_HERE,

base::Bind(&NativeBackendKWalletStub::AddLogin,