Shuffles and renames ash/common/wm classes

Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org

Committed: https://crrev.com/0702b27a85c1b650e1a7f162b7484b2a7f71cf6e
Cr-Commit-Position: refs/heads/master@{#397820}

[sky, 2016-06-03 18:03:31]

Sorry for the cat-5 patch.

[James Cook, 2016-06-03 20:10:47]

LGTM

https://codereview.chromium.org/2035543004/diff/60001/ash/aura/wm_root_window...
File ash/aura/wm_root_window_controller_aura.h (right):

https://codereview.chromium.org/2035543004/diff/60001/ash/aura/wm_root_window...
ash/aura/wm_root_window_controller_aura.h:40: wm::WmShelf* GetShelf() override;
My patch to move the shelf code is going to collide with this. Unless you tell
me otherwise, I'll wait for you to land first, then rebase on top of you.

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm/default_s...
File ash/common/wm/default_state.cc (right):

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm/default_s...
ash/common/wm/default_state.cc:58: WmShell* shell =
window_state->window()->GetShell();
Thanks for fixing local variable names.

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm_window.h#...
ash/common/wm_window.h:65: virtual WmShell* GetShell() const = 0;
Not for this CL: Do you think we'll need this going forward? It seems like
everyone will just end up calling WmShell::Get().

[sky, 2016-06-03 20:12:48]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035543004/60001

[sky, 2016-06-03 20:13:47]

I clicked the commit button, so hopefully it makes it through.

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2035543004/diff/60001/ash/common/wm_window.h#...
ash/common/wm_window.h:65: virtual WmShell* GetShell() const = 0;
On 2016/06/03 20:10:47, James Cook wrote:
> Not for this CL: Do you think we'll need this going forward? It seems like
> everyone will just end up calling WmShell::Get().

Agreed.

[sky, 2016-06-03 20:18:30]

Description was changed from

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
==========

to

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

[sky, 2016-06-03 20:18:30]

sky@chromium.org changed reviewers:
+ reveman@chromium.org

[sky, 2016-06-03 20:19:03]

TBR to reveman for exo again.

[reveman, 2016-06-03 20:42:31]

lgtm

[commit-bot: I haz the power, 2016-06-03 22:10:54]

Description was changed from

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

[commit-bot: I haz the power, 2016-06-03 22:10:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-03 22:12:41]

Description was changed from

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Shuffles and renames ash/common/wm classes

WmGlobals->WmShell
A bunch of classes that were in wm have moved to ash/common. Nuked the
wm:: workspace.
I initially wanted to keep this small, but it's easier to move move of
the classes together as less namespace collisions then.

BUG=616265
TEST=none
R=jamescook@chromium.org
TBR=reveman@chromium.org

Committed: https://crrev.com/0702b27a85c1b650e1a7f162b7484b2a7f71cf6e
Cr-Commit-Position: refs/heads/master@{#397820}
==========

[commit-bot: I haz the power, 2016-06-03 22:12:42]

Patchset 4 (id:??) landed as
https://crrev.com/0702b27a85c1b650e1a7f162b7484b2a7f71cf6e
Cr-Commit-Position: refs/heads/master@{#397820}