Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

Issue 2035543004: Shuffles and renames ash/common/wm classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: random changes for chrome tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_commands.h" 5 #include "ash/accelerators/accelerator_commands.h"
6 6
7 #include "ash/ash_switches.h" 7 #include "ash/ash_switches.h"
8 #include "ash/aura/wm_window_aura.h"
8 #include "ash/common/wm/window_state.h" 9 #include "ash/common/wm/window_state.h"
9 #include "ash/shell.h" 10 #include "ash/shell.h"
10 #include "ash/wm/aura/wm_window_aura.h"
11 #include "ash/wm/window_state_aura.h" 11 #include "ash/wm/window_state_aura.h"
12 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "build/build_config.h" 14 #include "build/build_config.h"
15 #include "chrome/browser/apps/app_browsertest_util.h" 15 #include "chrome/browser/apps/app_browsertest_util.h"
16 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_commands.h" 17 #include "chrome/browser/ui/browser_commands.h"
18 #include "chrome/browser/ui/browser_finder.h" 18 #include "chrome/browser/ui/browser_finder.h"
19 #include "chrome/browser/ui/browser_window.h" 19 #include "chrome/browser/ui/browser_window.h"
20 #include "chrome/common/chrome_switches.h" 20 #include "chrome/common/chrome_switches.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // When not in fullscreen, accelerators::ToggleMaximized toggles Maximized. 67 // When not in fullscreen, accelerators::ToggleMaximized toggles Maximized.
68 EXPECT_FALSE(window_state->IsMaximized()); 68 EXPECT_FALSE(window_state->IsMaximized());
69 ash::accelerators::ToggleMaximized(); 69 ash::accelerators::ToggleMaximized();
70 EXPECT_TRUE(window_state->IsMaximized()); 70 EXPECT_TRUE(window_state->IsMaximized());
71 ash::accelerators::ToggleMaximized(); 71 ash::accelerators::ToggleMaximized();
72 EXPECT_FALSE(window_state->IsMaximized()); 72 EXPECT_FALSE(window_state->IsMaximized());
73 73
74 // When in fullscreen accelerators::ToggleMaximized gets out of fullscreen. 74 // When in fullscreen accelerators::ToggleMaximized gets out of fullscreen.
75 EXPECT_FALSE(window_state->IsFullscreen()); 75 EXPECT_FALSE(window_state->IsFullscreen());
76 Browser* browser = chrome::FindBrowserWithWindow( 76 Browser* browser = chrome::FindBrowserWithWindow(
77 ash::wm::WmWindowAura::GetAuraWindow(window_state->window())); 77 ash::WmWindowAura::GetAuraWindow(window_state->window()));
78 ASSERT_TRUE(browser); 78 ASSERT_TRUE(browser);
79 chrome::ToggleFullscreenMode(browser); 79 chrome::ToggleFullscreenMode(browser);
80 EXPECT_TRUE(window_state->IsFullscreen()); 80 EXPECT_TRUE(window_state->IsFullscreen());
81 ash::accelerators::ToggleMaximized(); 81 ash::accelerators::ToggleMaximized();
82 EXPECT_FALSE(window_state->IsFullscreen()); 82 EXPECT_FALSE(window_state->IsFullscreen());
83 EXPECT_FALSE(window_state->IsMaximized()); 83 EXPECT_FALSE(window_state->IsMaximized());
84 ash::accelerators::ToggleMaximized(); 84 ash::accelerators::ToggleMaximized();
85 EXPECT_FALSE(window_state->IsFullscreen()); 85 EXPECT_FALSE(window_state->IsFullscreen());
86 EXPECT_TRUE(window_state->IsMaximized()); 86 EXPECT_TRUE(window_state->IsMaximized());
87 } 87 }
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 ash::accelerators::ToggleFullscreen(); 134 ash::accelerators::ToggleFullscreen();
135 EXPECT_TRUE(window_state->IsFullscreen()); 135 EXPECT_TRUE(window_state->IsFullscreen());
136 EXPECT_TRUE(IsInImmersiveFullscreen(window_state)); 136 EXPECT_TRUE(IsInImmersiveFullscreen(window_state));
137 137
138 ash::accelerators::ToggleFullscreen(); 138 ash::accelerators::ToggleFullscreen();
139 EXPECT_TRUE(IsInitialShowState(window_state)); 139 EXPECT_TRUE(IsInitialShowState(window_state));
140 140
141 // 2) ToggleFullscreen() should have no effect on windows which cannot be 141 // 2) ToggleFullscreen() should have no effect on windows which cannot be
142 // maximized. 142 // maximized.
143 ash::wm::WmWindowAura::GetAuraWindow(window_state->window()) 143 ash::WmWindowAura::GetAuraWindow(window_state->window())
144 ->SetProperty(aura::client::kCanMaximizeKey, false); 144 ->SetProperty(aura::client::kCanMaximizeKey, false);
145 ash::accelerators::ToggleFullscreen(); 145 ash::accelerators::ToggleFullscreen();
146 EXPECT_TRUE(IsInitialShowState(window_state)); 146 EXPECT_TRUE(IsInitialShowState(window_state));
147 147
148 // 3) Hosted apps. 148 // 3) Hosted apps.
149 Browser::CreateParams browser_create_params( 149 Browser::CreateParams browser_create_params(
150 Browser::CreateParams::CreateForApp("Test", true /* trusted_source */, 150 Browser::CreateParams::CreateForApp("Test", true /* trusted_source */,
151 gfx::Rect(), browser()->profile())); 151 gfx::Rect(), browser()->profile()));
152 152
153 Browser* app_host_browser = new Browser(browser_create_params); 153 Browser* app_host_browser = new Browser(browser_create_params);
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 CloseAppWindow(app_window); 306 CloseAppWindow(app_window);
307 } 307 }
308 } 308 }
309 309
310 INSTANTIATE_TEST_CASE_P(InitiallyRestored, 310 INSTANTIATE_TEST_CASE_P(InitiallyRestored,
311 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 311 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
312 Values(ui::SHOW_STATE_NORMAL)); 312 Values(ui::SHOW_STATE_NORMAL));
313 INSTANTIATE_TEST_CASE_P(InitiallyMaximized, 313 INSTANTIATE_TEST_CASE_P(InitiallyMaximized,
314 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 314 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
315 Values(ui::SHOW_STATE_MAXIMIZED)); 315 Values(ui::SHOW_STATE_MAXIMIZED));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698