Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is duplicated in a lot of places, rtenneti@ suggested to implement these methods in base/ and remove duplicated code.

BUG=

Committed: https://crrev.com/239603426472eea818a54f08a0d419b6c1c40a9b
Cr-Commit-Position: refs/heads/master@{#386845}

[Zhongyi Shi, 2016-04-12 00:22:38]

Patchset #1 (id:1) has been deleted

[Zhongyi Shi, 2016-04-12 00:22:44]

Patchset #1 (id:20001) has been deleted

[Zhongyi Shi, 2016-04-12 00:24:29]

Description was changed from

==========
Implement IsAsciiUpper in base/strings/string_util.h

BUG=
==========

to

==========
Implement IsAsciiUpper in base/strings/string_util.h

BUG=
==========

[Zhongyi Shi, 2016-04-12 00:24:30]

zhongyi@chromium.org changed reviewers:
+ brettw@chromium.org

[Zhongyi Shi, 2016-04-12 00:26:54]

Hi Brett,

I am trying to move the ascii_isupper method impl to string/string_util.h to
keep code clean. This method was needed when our internal QUIC code merged to
chromium. PTAL, thanks!

Cherie

[brettw, 2016-04-12 16:28:04]

I'm not a fan of adding base helper functions for one caller on the off chance
that somebody else will use it. And this helper function is simple enough that I
don't think duplication is a big deal.

That said, this does seem to go with the other functions here, and is useful
from time-to-time. If you want to do this kind of thing, I'm supportive but we
should also add a lower-case version for consistency and change the "obvious"
cases in the code to use the new helpers so the functions are actually used.

I did:
  git grep "'A'"|grep "'Z'"
and I can see ~15 non-third-party files we can obviously update to use the new
helper (probably similar for the lower-case variant).

[Zhongyi Shi, 2016-04-12 21:14:23]

Description was changed from

==========
Implement IsAsciiUpper in base/strings/string_util.h

BUG=
==========

to

==========
Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove
duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is
duplicated in a lot of places, rtenneti@ suggested to implement these methods in
base/ and remove duplicated code.

BUG=
==========

[Zhongyi Shi, 2016-04-12 21:14:23]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-04-12 21:16:41]

zhongyi@chromium.org changed reviewers:
- rch@chromium.org

[Zhongyi Shi, 2016-04-12 21:21:41]

Thanks Brett, though I did agree these two functions are really simple and
people usually write the code rather than calling those methods, it will be
useful when we need a function pointer, or function object like the usage in
spdy_util.cc.

That being said, I added impl of IsAsciiLower as well and removed duplicated
code in non-thirdparty folders. PTAL!

[brettw, 2016-04-12 21:41:07]

lgtm

https://codereview.chromium.org/1878083002/diff/80001/components/crash/conten...
File components/crash/content/app/breakpad_linux.cc (right):

https://codereview.chromium.org/1878083002/diff/80001/components/crash/conten...
components/crash/content/app/breakpad_linux.cc:215: bool my_isxdigit(char c) {
I think you can delete this and replace the only caller with base::IsHexDigit

https://codereview.chromium.org/1878083002/diff/80001/net/quic/test_tools/cry...
File net/quic/test_tools/crypto_test_utils.cc (right):

https://codereview.chromium.org/1878083002/diff/80001/net/quic/test_tools/cry...
net/quic/test_tools/crypto_test_utils.cc:59: bool HexChar(char c, uint8_t*
value) {
Optional: this whole function can be replaced with:
  if (!base::IsHexDigit(c))
    return false;
  *value = base::HexDigitToInt(c);
  return true;

[Zhongyi Shi, 2016-04-12 21:57:41]

https://codereview.chromium.org/1878083002/diff/80001/net/quic/test_tools/cry...
File net/quic/test_tools/crypto_test_utils.cc (right):

https://codereview.chromium.org/1878083002/diff/80001/net/quic/test_tools/cry...
net/quic/test_tools/crypto_test_utils.cc:59: bool HexChar(char c, uint8_t*
value) {
On 2016/04/12 21:41:07, brettw wrote:
> Optional: this whole function can be replaced with:
>   if (!base::IsHexDigit(c))
>     return false;
>   *value = base::HexDigitToInt(c);
>   return true;

Thanks for catching this, this lives in the QUIC shared code. I will upload a
internal CL to fix this and it will be merged to chromium next week.

[Zhongyi Shi, 2016-04-12 21:57:48]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:58:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1878083002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1878083002/80001

[commit-bot: I haz the power, 2016-04-12 23:13:28]

Description was changed from

==========
Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove
duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is
duplicated in a lot of places, rtenneti@ suggested to implement these methods in
base/ and remove duplicated code.

BUG=
==========

to

==========
Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove
duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is
duplicated in a lot of places, rtenneti@ suggested to implement these methods in
base/ and remove duplicated code.

BUG=
==========

[commit-bot: I haz the power, 2016-04-12 23:13:29]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-04-12 23:15:25]

Description was changed from

==========
Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove
duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is
duplicated in a lot of places, rtenneti@ suggested to implement these methods in
base/ and remove duplicated code.

BUG=
==========

to

==========
Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h and remove
duplicate code in the code base.

This is initially introduced by Quic Merge process. As we found the code is
duplicated in a lot of places, rtenneti@ suggested to implement these methods in
base/ and remove duplicated code.

BUG=

Committed: https://crrev.com/239603426472eea818a54f08a0d419b6c1c40a9b
Cr-Commit-Position: refs/heads/master@{#386845}
==========

[commit-bot: I haz the power, 2016-04-12 23:15:27]

Patchset 3 (id:??) landed as
https://crrev.com/239603426472eea818a54f08a0d419b6c1c40a9b
Cr-Commit-Position: refs/heads/master@{#386845}