Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

chrome/common/extensions/command.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/command.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 176 matching lines @@
         key = ui::VKEY_MEDIA_NEXT_TRACK;
       } else if (tokens[i] == values::kKeyMediaPlayPause &&
                  should_parse_media_keys) {
         key = ui::VKEY_MEDIA_PLAY_PAUSE;
       } else if (tokens[i] == values::kKeyMediaPrevTrack &&
                  should_parse_media_keys) {
         key = ui::VKEY_MEDIA_PREV_TRACK;
       } else if (tokens[i] == values::kKeyMediaStop &&
                  should_parse_media_keys) {
         key = ui::VKEY_MEDIA_STOP;
-      } else if (tokens[i].size() == 1 &&
-                 tokens[i][0] >= 'A' && tokens[i][0] <= 'Z') {
+      } else if (tokens[i].size() == 1 && base::IsAsciiUpper(tokens[i][0])) {
         key = static_cast<ui::KeyboardCode>(ui::VKEY_A + (tokens[i][0] - 'A'));
-      } else if (tokens[i].size() == 1 &&
-                 tokens[i][0] >= '0' && tokens[i][0] <= '9') {
+      } else if (tokens[i].size() == 1 && base::IsAsciiDigit(tokens[i][0])) {
         key = static_cast<ui::KeyboardCode>(ui::VKEY_0 + (tokens[i][0] - '0'));
       } else {
         key = ui::VKEY_UNKNOWN;
         break;
       }
     } else {
       *error = ErrorUtils::FormatErrorMessageUTF16(
           errors::kInvalidKeyBinding,
           base::IntToString(index),
           platform_key,
@@ skipping 339 matching lines @@
       accelerator_ = accelerator;
       command_name_ = command_name;
       description_ = description;
       global_ = global;
     }
   }
   return true;
 }
 
 }  // namespace extensions