Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

components/omnibox/browser/in_memory_url_index_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <fstream>
 
@@ skipping 230 matching lines @@
 
   sql::Connection& db(GetDB());
   ASSERT_TRUE(db.is_open());
   {
     sql::Transaction transaction(&db);
     transaction.Begin();
     while (!proto_file.eof()) {
       proto_file.getline(sql_cmd_line, kCommandBufferMaxSize);
       if (!proto_file.eof()) {
         // We only process lines which begin with a upper-case letter.
-        // TODO(mrossetti): Can iswupper() be used here?
-        if (sql_cmd_line[0] >= 'A' && sql_cmd_line[0] <= 'Z') {
+        if (base::IsAsciiUpper(sql_cmd_line[0])) {
           std::string sql_cmd(sql_cmd_line);
           sql::Statement sql_stmt(db.GetUniqueStatement(sql_cmd_line));
           EXPECT_TRUE(sql_stmt.Run());
         }
       }
     }
     transaction.Commit();
   }
 
   // Update the last_visit_time table column in the "urls" table
@@ skipping 1047 matching lines @@
   ASSERT_TRUE(GetCacheFilePath(&full_file_path));
   std::vector<base::FilePath::StringType> actual_parts;
   full_file_path.GetComponents(&actual_parts);
   ASSERT_EQ(expected_parts.size(), actual_parts.size());
   size_t count = expected_parts.size();
   for (size_t i = 0; i < count; ++i)
     EXPECT_EQ(expected_parts[i], actual_parts[i]);
   // Must clear the history_dir_ to satisfy the dtor's DCHECK.
   set_history_dir(base::FilePath());
 }