Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: net/cert/internal/verify_name_match.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_name_match.cc
diff --git a/net/cert/internal/verify_name_match.cc b/net/cert/internal/verify_name_match.cc
index 444f3c97f30b59e6aa258cac2f3a8668930f6af3..723c25752860a9b02c3876fed174bf2ff321f911 100644
--- a/net/cert/internal/verify_name_match.cc
+++ b/net/cert/internal/verify_name_match.cc
@@ -4,6 +4,7 @@
#include "net/cert/internal/verify_name_match.h"
+#include "base/strings/string_util.h"
#include "base/tuple.h"
#include "net/cert/internal/parse_name.h"
#include "net/der/input.h"
@@ -79,7 +80,7 @@ WARN_UNUSED_RESULT bool NormalizeDirectoryString(
std::string::const_iterator next_iter = read_iter + 1;
if (next_iter != output->end() && *next_iter != ' ')
*(write_iter++) = ' ';
- } else if (c >= 'A' && c <= 'Z') {
+ } else if (base::IsAsciiUpper(c)) {
// Fold case.
*(write_iter++) = c + ('a' - 'A');
} else {
@@ -89,7 +90,7 @@ WARN_UNUSED_RESULT bool NormalizeDirectoryString(
case ENFORCE_PRINTABLE_STRING:
// See NormalizePrintableStringValue comment for the acceptable list
// of characters.
- if (!((c >= 'a' && c <= 'z') || (c >= '\'' && c <= ':') || c == '=' ||
+ if (!(base::IsAsciiLower(c) || (c >= '\'' && c <= ':') || c == '=' ||
c == '?'))
return false;
break;

Powered by Google App Engine
This is Rietveld 408576698