Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

net/quic/spdy_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/spdy_utils.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
 #include "net/spdy/spdy_frame_builder.h"
 #include "net/spdy/spdy_framer.h"
 #include "net/spdy/spdy_protocol.h"
 #include "url/gurl.h"
 
 using std::string;
 using std::vector;
 
 namespace net {
 
-bool ascii_isupper(unsigned char c) {
-  return c >= 'A' && c <= 'Z';
-}
-
 // static
 string SpdyUtils::SerializeUncompressedHeaders(const SpdyHeaderBlock& headers) {
   SpdyMajorVersion spdy_version = HTTP2;
 
   size_t length = SpdyFramer::GetSerializedLength(spdy_version, &headers);
   SpdyFrameBuilder builder(length, spdy_version);
   SpdyFramer framer(spdy_version);
   framer.SerializeHeaderBlockWithoutCompression(&builder, headers);
   SpdySerializedFrame block(builder.take());
   return string(block.data(), length);
@@ skipping 78 matching lines @@
                                         size_t* final_byte_offset,
                                         SpdyHeaderBlock* trailers) {
   for (const auto& p : header_list) {
     const string& name = p.first;
     if (name.empty() || name[0] == ':') {
       DVLOG(1) << "Trailers must not be empty, and must not contain pseudo-"
                << "headers. Found: '" << name << "'";
       return false;
     }
 
-    if (std::any_of(name.begin(), name.end(), ascii_isupper)) {
+    if (std::any_of(name.begin(), name.end(), base::IsAsciiUpper<char>)) {
       DVLOG(1) << "Malformed header: Header name " << name
                << " contains upper-case characters.";
       return false;
     }
 
     if (trailers->find(name) != trailers->end()) {
       DVLOG(1) << "Duplicate header '" << name << "' found in trailers.";
       return false;
     }
 
@@ skipping 50 matching lines @@
   return GURL(GetUrlFromHeaderBlock(headers)).host();
 }
 
 // static
 bool SpdyUtils::UrlIsValid(const SpdyHeaderBlock& headers) {
   string url(GetUrlFromHeaderBlock(headers));
   return url != "" && GURL(url).is_valid();
 }
 
 }  // namespace net