Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

net/quic/test_tools/crypto_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/test_tools/crypto_test_utils.h"
 
+#include "base/strings/string_util.h"
 #include "net/quic/crypto/channel_id.h"
 #include "net/quic/crypto/common_cert_set.h"
 #include "net/quic/crypto/crypto_handshake.h"
 #include "net/quic/crypto/quic_crypto_server_config.h"
 #include "net/quic/crypto/quic_decrypter.h"
 #include "net/quic/crypto/quic_encrypter.h"
 #include "net/quic/crypto/quic_random.h"
 #include "net/quic/quic_clock.h"
 #include "net/quic/quic_crypto_client_stream.h"
 #include "net/quic/quic_crypto_server_stream.h"
@@ skipping 31 matching lines @@
 
   const vector<CryptoHandshakeMessage>& messages() const { return messages_; }
 
  private:
   bool error_;
   vector<CryptoHandshakeMessage> messages_;
 };
 
 // HexChar parses |c| as a hex character. If valid, it sets |*value| to the
 // value of the hex character and returns true. Otherwise it returns false.
 bool HexChar(char c, uint8_t* value) {

[brettw, 2016/04/12 21:41:07]

Optional: this whole function can be replaced with:
  if (!base::IsHexDigit(c))
    return false;
  *value = base::HexDigitToInt(c);
  return true;

[Zhongyi Shi, 2016/04/12 21:57:41]

Thanks for catching this, this lives in the QUIC shared code. I will upload a
internal CL to fix this and it will be merged to chromium next week.

-  if (c >= '0' && c <= '9') {
+  if (base::IsAsciiDigit(c)) {
     *value = c - '0';
     return true;
   }
   if (c >= 'a' && c <= 'f') {
     *value = c - 'a' + 10;
     return true;
   }
   if (c >= 'A' && c <= 'F') {
     *value = c - 'A' + 10;
     return true;
@@ skipping 571 matching lines @@
 
   ASSERT_EQ(0u, crypto_framer.InputBytesRemaining());
 
   for (const CryptoHandshakeMessage& message : crypto_visitor.messages()) {
     dest_stream->OnHandshakeMessage(message);
   }
 }
 
 }  // namespace test
 }  // namespace net