content/renderer/pepper/url_request_info_util.cc - Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/url_request_info_util.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/crash/content/app/breakpad_linux.cc ('K') | « content/renderer/pepper/event_conversion.cc ('k') | net/base/parse_number.cc » ('j') | net/quic/test_tools/crypto_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/url_request_info_util.cc

diff --git a/content/renderer/pepper/url_request_info_util.cc b/content/renderer/pepper/url_request_info_util.cc

index 157fc9c0ee18a318542f2a67e63a76f2222fd467..4d8aa14f55f658f21fee93a0e3b137b1634dac3a 100644

--- a/content/renderer/pepper/url_request_info_util.cc

+++ b/content/renderer/pepper/url_request_info_util.cc

@@ -113,8 +113,8 @@ std::string FilterStringForXRequestedWithValue(const std::string& s) {

char c = s[i];

// Allow ASCII digits, letters, periods, commas, and underscores. (Ignore

// all other characters.)

- if ((c >= '0' && c <= '9') || (c >= 'A' && c <= 'Z') ||

- (c >= 'a' && c <= 'z') || (c == '.') || (c == ',') || (c == '_'))

+ if (base::IsAsciiDigit(c) || base::IsAsciiAlpha(c) || (c == '.') ||

+ (c == ',') || (c == '_'))

rv.push_back(c);

}

return rv;

« components/crash/content/app/breakpad_linux.cc ('K') | « content/renderer/pepper/event_conversion.cc ('k') | net/base/parse_number.cc » ('j') | net/quic/test_tools/crypto_test_utils.cc » ('J')