chrome/browser/devtools/devtools_file_system_indexer.cc - Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_file_system_indexer.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/strings/string_util.h ('k') | chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc » ('j') | components/crash/content/app/breakpad_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_file_system_indexer.cc

diff --git a/chrome/browser/devtools/devtools_file_system_indexer.cc b/chrome/browser/devtools/devtools_file_system_indexer.cc

index 3eb1527f6bd087a384e91475187e4836ac649150..a493a4f1e468c1d1e0c0b60a31629fdae3149fb5 100644

--- a/chrome/browser/devtools/devtools_file_system_indexer.cc

+++ b/chrome/browser/devtools/devtools_file_system_indexer.cc

@@ -17,6 +17,7 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/stl_util.h"

+#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "content/public/browser/browser_thread.h"

@@ -92,7 +93,7 @@ TrigramChar TrigramCharForChar(char c) {

char ch = static_cast<char>(i);

if (ch == '\t')

ch = ' ';

- if (ch >= 'A' && ch <= 'Z')

+ if (base::IsAsciiUpper(ch))

ch = ch - 'A' + 'a';

bool is_binary_char = ch < 9 || (ch >= 14 && ch < 32) || ch == 127;