Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/omnibox/browser/in_memory_url_index_unittest.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/in_memory_url_index_unittest.cc
diff --git a/components/omnibox/browser/in_memory_url_index_unittest.cc b/components/omnibox/browser/in_memory_url_index_unittest.cc
index c8dd047d6b5083afe96a91f5202f3e14447717d7..e6a85068893febad4e834315cf7b335cdd5769c0 100644
--- a/components/omnibox/browser/in_memory_url_index_unittest.cc
+++ b/components/omnibox/browser/in_memory_url_index_unittest.cc
@@ -248,8 +248,7 @@ void InMemoryURLIndexTest::SetUp() {
proto_file.getline(sql_cmd_line, kCommandBufferMaxSize);
if (!proto_file.eof()) {
// We only process lines which begin with a upper-case letter.
- // TODO(mrossetti): Can iswupper() be used here?
- if (sql_cmd_line[0] >= 'A' && sql_cmd_line[0] <= 'Z') {
+ if (base::IsAsciiUpper(sql_cmd_line[0])) {
std::string sql_cmd(sql_cmd_line);
sql::Statement sql_stmt(db.GetUniqueStatement(sql_cmd_line));
EXPECT_TRUE(sql_stmt.Run());

Powered by Google App Engine
This is Rietveld 408576698