Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: chrome/common/extensions/command.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/command.cc
diff --git a/chrome/common/extensions/command.cc b/chrome/common/extensions/command.cc
index f2290dca4def611d4827ec80de5ac90ec64bd843..2eb3bd7fa0f3ffb0f2a60b05b3c56d4a93319274 100644
--- a/chrome/common/extensions/command.cc
+++ b/chrome/common/extensions/command.cc
@@ -194,11 +194,9 @@ ui::Accelerator ParseImpl(const std::string& accelerator,
} else if (tokens[i] == values::kKeyMediaStop &&
should_parse_media_keys) {
key = ui::VKEY_MEDIA_STOP;
- } else if (tokens[i].size() == 1 &&
- tokens[i][0] >= 'A' && tokens[i][0] <= 'Z') {
+ } else if (tokens[i].size() == 1 && base::IsAsciiUpper(tokens[i][0])) {
key = static_cast<ui::KeyboardCode>(ui::VKEY_A + (tokens[i][0] - 'A'));
- } else if (tokens[i].size() == 1 &&
- tokens[i][0] >= '0' && tokens[i][0] <= '9') {
+ } else if (tokens[i].size() == 1 && base::IsAsciiDigit(tokens[i][0])) {
key = static_cast<ui::KeyboardCode>(ui::VKEY_0 + (tokens[i][0] - '0'));
} else {
key = ui::VKEY_UNKNOWN;

Powered by Google App Engine
This is Rietveld 408576698