Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/test_runner/test_common.h

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_common.h
diff --git a/components/test_runner/test_common.h b/components/test_runner/test_common.h
index d1e758b43b6f7eecc3a4bd16ffc3f9e139409c23..57e9747f989dc570affd66e27d5bd5379defe905 100644
--- a/components/test_runner/test_common.h
+++ b/components/test_runner/test_common.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/strings/string_util.h"
#include "components/test_runner/test_runner_export.h"
#include "third_party/WebKit/public/web/WebNavigationPolicy.h"
@@ -15,7 +16,7 @@ class GURL;
namespace test_runner {
inline bool IsASCIIAlpha(char ch) {
- return (ch | 0x20) >= 'a' && (ch | 0x20) <= 'z';
+ return base::IsAsciiLower(ch | 0x20);
}
inline bool IsNotASCIIAlpha(char ch) {

Powered by Google App Engine
This is Rietveld 408576698