Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1839)

Unified Diff: content/renderer/pepper/event_conversion.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/event_conversion.cc
diff --git a/content/renderer/pepper/event_conversion.cc b/content/renderer/pepper/event_conversion.cc
index 8d9a3c3a7460d3a6526f8b9bd16d46f3d9d62823..4f7ef8c532da0f1d0b77b1657b469577d96a8d0b 100644
--- a/content/renderer/pepper/event_conversion.cc
+++ b/content/renderer/pepper/event_conversion.cc
@@ -533,9 +533,8 @@ void GetKeyCode(const std::string& char_text,
base::string16 char_text16 = base::UTF8ToUTF16(char_text);
DCHECK_EQ(char_text16.size(), 1U);
vk_text = vk_code = char_text16[0];
- *needs_shift_modifier =
- (vk_code & 0xFF) >= 'A' && (vk_code & 0xFF) <= 'Z';
- if ((vk_code & 0xFF) >= 'a' && (vk_code & 0xFF) <= 'z')
+ *needs_shift_modifier = base::IsAsciiUpper(vk_code & 0xFF);
+ if (base::IsAsciiLower(vk_code & 0xFF))
vk_code -= 'a' - 'A';
*generate_char = true;
}

Powered by Google App Engine
This is Rietveld 408576698