Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

net/base/parse_number.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/parse_number.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
 
 namespace net {
 
 namespace {
 
 // The string to number conversion functions in //base include the type in the
 // name (like StringToInt64()). The following wrapper methods create a
 // consistent interface to StringToXXX() that calls the appropriate //base
 // version. This simplifies writing generic code with a template.
 
@@ skipping 25 matching lines @@
 bool ParseIntHelper(const base::StringPiece& input,
                     ParseIntFormat format,
                     T* output,
                     ParseIntError* optional_error) {
   // Check that the input matches the format before calling StringToNumber().
   // Numbers must start with either a digit or a negative sign.
   if (input.empty())
     return SetError(ParseIntError::FAILED_PARSE, optional_error);
 
   bool starts_with_negative = input[0] == '-';
-  bool starts_with_digit = input[0] >= '0' && input[0] <= '9';
+  bool starts_with_digit = base::IsAsciiDigit(input[0]);
 
   if (!starts_with_digit) {
     if (format == ParseIntFormat::NON_NEGATIVE || !starts_with_negative)
       return SetError(ParseIntError::FAILED_PARSE, optional_error);
   }
 
   // Dispatch to the appropriate flavor of base::StringToXXX() by calling one of
   // the type-specific overloads.
   T result;
   if (StringToNumber(input, &result)) {
@@ skipping 52 matching lines @@
 }
 
 bool ParseUint64(const base::StringPiece& input,
                  uint64_t* output,
                  ParseIntError* optional_error) {
   return ParseIntHelper(input, ParseIntFormat::NON_NEGATIVE, output,
                         optional_error);
 }
 
 }  // namespace net