content/browser/renderer_host/media/media_stream_manager_unittest.cc - Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_manager_unittest.cc

Issue 1878083002: Implement IsAsciiUpper and IsAsciiLower in base/strings/string_util.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/crash/content/app/breakpad_linux.cc ('K') | « components/test_runner/test_common.h ('k') | content/renderer/pepper/event_conversion.cc » ('j') | net/quic/test_tools/crypto_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/media_stream_manager_unittest.cc b/content/browser/renderer_host/media/media_stream_manager_unittest.cc

index 51c0579b3148133390bda74cb07b878f3fd1b0de..ff2fadaaaf08913c166b02cbc14f2e0faf588688 100644

--- a/content/browser/renderer_host/media/media_stream_manager_unittest.cc

+++ b/content/browser/renderer_host/media/media_stream_manager_unittest.cc

@@ -13,6 +13,7 @@

#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

+#include "base/strings/string_util.h"

#include "base/thread_task_runner_handle.h"

#include "build/build_config.h"

#include "content/browser/browser_thread_impl.h"

@@ -301,7 +302,7 @@ TEST_F(MediaStreamManagerTest, DeviceID) {

EXPECT_NE(unique_other_id, hashed_other_id);

EXPECT_EQ(hashed_other_id.size(), 64U);

for (const char& c : hashed_other_id)

- EXPECT_TRUE((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f'));

+ EXPECT_TRUE(base::IsAsciiDigit(c) || (c >= 'a' && c <= 'f'));

}

TEST_F(MediaStreamManagerTest, EnumerationOutputDevices) {