Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed)

Created:
4 years, 8 months ago by eakuefner
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Move extensions_to_load and output_profile_path into browser_options This CL both 1. Moves extension_to_load and output_profile_path into browser_options, and 2. Refactors SupportsOptions to take browser_options instead of finder_options. BUG=catapult:#2102 R=nednguyen Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/40d19cec3ce8b1040e24f2ae3b42052eabc753a1

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -56 lines) Patch
M telemetry/telemetry/internal/app/possible_app.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome/android_browser_backend.py View 1 chunk +3 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/android_browser_finder.py View 2 chunks +3 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 2 chunks +3 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 2 chunks +4 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py View 2 chunks +5 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_test_case.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 2 chunks +4 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py View 1 chunk +4 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py View 1 chunk +2 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/browser/browser_finder.py View 1 chunk +2 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/browser/browser_options.py View 2 chunks +5 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/browser/extension_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/browser/possible_browser.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
eakuefner
PTAL
4 years, 8 months ago (2016-04-08 21:51:52 UTC) #1
nednguyen
lgtm, but watch out for code in chromium side that references this. Also let's not ...
4 years, 8 months ago (2016-04-08 22:05:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874473006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874473006/1
4 years, 8 months ago (2016-04-11 18:08:00 UTC) #5
eakuefner
I'll wait for https://codereview.chromium.org/1881573002 to land and then land this, so that we don't block ...
4 years, 8 months ago (2016-04-11 18:31:49 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/2801)
4 years, 8 months ago (2016-04-11 18:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874473006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874473006/20001
4 years, 8 months ago (2016-04-12 17:55:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:11:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698