Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1881573002: [Perf] Guard against impending output_profile_path option move. (Closed)

Created:
4 years, 8 months ago by eakuefner
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Perf] Guard against impending output_profile_path option move. Only the profile generation stuff in tools/perf uses output_profile_path; these will break the Catapult roll if we don't guard them. BUG=catapult:#2102 Committed: https://crrev.com/c4ad91d219cc9061443b2ab5317b56efd68b121e Cr-Commit-Position: refs/heads/master@{#386449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M tools/perf/profile_creators/extension_profile_extender_unittest.py View 1 chunk +6 lines, -1 line 0 comments Download
M tools/perf/profile_creators/profile_extender.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/profile_creators/profile_generator.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
eakuefner
Ned PTAL.
4 years, 8 months ago (2016-04-11 18:30:12 UTC) #2
nednguyen
lgtm
4 years, 8 months ago (2016-04-11 18:30:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881573002/1
4 years, 8 months ago (2016-04-11 18:31:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 20:04:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:06:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4ad91d219cc9061443b2ab5317b56efd68b121e
Cr-Commit-Position: refs/heads/master@{#386449}

Powered by Google App Engine
This is Rietveld 408576698