telemetry/telemetry/internal/browser/browser_options.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/browser_options.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/browser_finder.py ('k') | telemetry/telemetry/internal/browser/browser_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/browser/browser_options.py

diff --git a/telemetry/telemetry/internal/browser/browser_options.py b/telemetry/telemetry/internal/browser/browser_options.py

index 3d7ac793b1ad649d7c1caa28e8476658ac144e23..be5b26bf8c639b3430f584fd8af6913ea86bc646 100644

--- a/telemetry/telemetry/internal/browser/browser_options.py

+++ b/telemetry/telemetry/internal/browser/browser_options.py

@@ -37,11 +37,6 @@ class BrowserFinderOptions(optparse.Values):

self.device = None

self.cros_ssh_identity = None

- self.extensions_to_load = []

- # If set, copy the generated profile to this path on exit.

- self.output_profile_path = None

self.cros_remote = None

self.profiler = None

@@ -239,6 +234,11 @@ class BrowserOptions(object):

self.browser_type = None

self.show_stdout = False

+ self.extensions_to_load = []

+ # If set, copy the generated profile to this path on exit.

+ self.output_profile_path = None

# When set to True, the browser will use the default profile. Telemetry

# will not provide an alternate profile directory.

self.dont_override_profile = False

« no previous file with comments | « telemetry/telemetry/internal/browser/browser_finder.py ('k') | telemetry/telemetry/internal/browser/browser_unittest.py » ('j') | no next file with comments »