telemetry/telemetry/internal/backends/chrome/android_browser_finder.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/android_browser_backend.py ('k') | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

diff --git a/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

index daf485c3bfb48250806e3fca2c8bcfd1587a102f..addae0f3e3aa5595d1f176337894a64c5eff468f 100644

--- a/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

+++ b/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

@@ -119,9 +119,7 @@ class PossibleAndroidBrowser(possible_browser.PossibleBrowser):

self._InitPlatformIfNeeded()

browser_backend = android_browser_backend.AndroidBrowserBackend(

self._platform_backend,

- finder_options.browser_options, self._backend_settings,

- output_profile_path=finder_options.output_profile_path,

- extensions_to_load=finder_options.extensions_to_load)

+ finder_options.browser_options, self._backend_settings)

try:

return browser.Browser(

browser_backend, self._platform_backend, self._credentials_path)

@@ -135,8 +133,8 @@ class PossibleAndroidBrowser(possible_browser.PossibleBrowser):

raise original_exception[0], original_exception[1], original_exception[2]

- def SupportsOptions(self, finder_options):

- if len(finder_options.extensions_to_load) != 0:

+ def SupportsOptions(self, browser_options):

+ if len(browser_options.extensions_to_load) != 0:

return False

return True